Measure current batch byte size and event count#18160
Merged
andsel merged 10 commits intoelastic:mainfrom Sep 26, 2025
Merged
Conversation
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
This pull request does not have a backport label. Could you fix it @andsel? 🙏
|
…keep the values correlated
…ocument count and batch bytes size)
…tric instance stored in the metric store.
…size and event_count
2e3ea64 to
00a395b
Compare
…not the last value
jsvd
reviewed
Sep 25, 2025
logstash-core/src/main/java/org/logstash/execution/QueueReadClientBatchMetrics.java
Outdated
Show resolved
Hide resolved
logstash-core/src/main/java/org/logstash/execution/QueueReadClientBatchMetrics.java
Outdated
Show resolved
Hide resolved
logstash-core/src/main/java/org/logstash/instrument/metrics/MetricExt.java
Outdated
Show resolved
Hide resolved
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
|
💛 Build succeeded, but was flaky
Failed CI Steps
History
cc @andsel |
jsvd
approved these changes
Sep 25, 2025
Member
jsvd
left a comment
There was a problem hiding this comment.
LGTM
When testing I noticed that the branch this is built on has a custom config/logstash.yml with an uncommented sample_mode setting https://github.com/andsel/logstash/blob/feature/current_metric_byte_size_event_count/config/logstash.yml#L57, so be careful in merging to ensure this change doesn't carry to main branch.
Contributor
Author
v1v
pushed a commit
that referenced
this pull request
Oct 21, 2025
Exposes the current batch size in terms of events and estimated memory consumption. Introduce a new gauge metric to collect list of values, used a a couple, the first element count of events in the batch and the second one is the estimated memory occupation of the batch. This list is later grabbed in the API layer to populate the two current values for `event_count` and `batch_size`. Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Release notes
Implements current batch event count and byte size metrics.
What does this PR do?
Introduce a new gauge metric to collect list of values, used a a couple, the first element count of events in the batch and the second one is the estimated memory occupation of the batch.
This list is later grabbed in the API layer to populate the two
currentvalues forevent_countandbatch_size.Why is it important/What is the impact to the user?
Exposes the current batch size in terms of events and estimated memory consumption.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
How to test this PR locally
Start Logstash with
pipeline.batch.metrics.sampling_modeset tofullrunning an HTTP input pipeline, load it withwrkand verify that the metric APIpipelines.main.batch.event_count.currentandpipelines.main.batch.byte_size.currentgoes down to 0 whenwrkis interrupted and gets a value other than 0 when the loadwrkresumes.input_sample.txtwith some contentsend_file.luaasconfig/logstash.yml:wrk, checking the metrics:Related issues